Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Re-opened elsewhere] Allow where() to work with a Series and other=cudf.NA #8977

Closed
wants to merge 10 commits into from
Closed

[Re-opened elsewhere] Allow where() to work with a Series and other=cudf.NA #8977

wants to merge 10 commits into from

Conversation

sarahyurick
Copy link
Contributor

@sarahyurick sarahyurick commented Aug 5, 2021 •
edited
Loading

Fixes #8969. Currently, the assertion fails when handling a cudf.NA versus pd.NA because the column's dtypes are different; Pandas makes it an object where as we make it a float64/int64.

Update: I just use check_dtype=False in the assert_eq() function.

@sarahyurick sarahyurick requested a review from a team as a code owner August 5, 2021 18:54
@sarahyurick sarahyurick self-assigned this Aug 5, 2021
@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 5, 2021
@sarahyurick sarahyurick added bug Something isn't working non-breaking Non-breaking change labels Aug 5, 2021
@sarahyurick sarahyurick marked this pull request as draft August 5, 2021 18:55
@sarahyurick sarahyurick marked this pull request as ready for review August 10, 2021 13:26
@codecov
Copy link

codecov bot commented Aug 11, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@f6ce668). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #8977   +/-   ##
===============================================
  Coverage                ?   10.57%           
===============================================
  Files                   ?      116           
  Lines                   ?    19081           
  Branches                ?        0           
===============================================
  Hits                    ?     2018           
  Misses                  ?    17063           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6ce668...6cb222b. Read the comment docs.

shwina
shwina approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@shwina shwina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sarahyurick sarahyurick mentioned this pull request Aug 11, 2021
Merged
@sarahyurick sarahyurick changed the title Allow where() to work with a Series and other=cudf.NA [Re-opened elsewhere] Allow where() to work with a Series and other=cudf.NA Aug 11, 2021
@sarahyurick
Copy link
Contributor Author

Checks failing due to git commit issues, re-opened at #9019.

rapids-bot bot pushed a commit that referenced this pull request Aug 11, 2021
@sarahyurick
Allow where() to work with a Series and other=cudf.NA (#9019)
7461b20 
Fixes #8969.

Duplicate of #8977 - some of the checks are erroring and I'm seeing strange messages about the git commits, so I'm re-opening the PR here to see if that fixes it.

Authors:
  - Sarah Yurick (https://github.com/sarahyurick)

Approvers:
  - Ashwin Srinath (https://github.com/shwina)

URL: #9019
@sarahyurick sarahyurick deleted the where_series_other branch September 21, 2022 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwina shwina shwina approved these changes

@trxcllnt trxcllnt Awaiting requested review from trxcllnt

@cwharris cwharris Awaiting requested review from cwharris

Assignees

@sarahyurick sarahyurick

Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Allow where() to work with a Series and other=cudf.NA
2 participants
@sarahyurick @shwina